Set LeaderElectionNamespace to PodNamespace (#5405)

* Set LeaderElectionNamespace to PodNamespace Signed-off-by: Ali Aqel <aliaqel@stripe.com> * update changelog Signed-off-by: Ali Aqel <aliaqel@stripe.com> * move changelog to unreleased Signed-off-by: Ali Aqel <aliaqel@stripe.com> * fix changelog Signed-off-by: Ali Aqel <aliaqel@stripe.com> * fix changelog ordering Signed-off-by: Ali Aqel <aliaqel@stripe.com> * fix changelog per comments Signed-off-by: Ali Aqel <aliaqel@stripe.com> --------- Signed-off-by: Ali Aqel <aliaqel@stripe.com>
kedacore · Jan 18, 2024 · 367fcd3 · 367fcd3
1 parent b52529b
commit 367fcd3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -135,6 +135,7 @@ Here is an overview of all new **experimental** features:
 - **General**: Prevented memory leak generated by not correctly cleaning http connections ([#5248](https://github.com/kedacore/keda/issues/5248))
 - **General**: Prevented stuck status due to timeouts during scalers generation ([#5083](https://github.com/kedacore/keda/issues/5083))
 - **General**: ScaledObject Validating Webhook should support `dry-run=server` requests ([#5306](https://github.com/kedacore/keda/issues/5306))
+- **General**: Set `LeaderElectionNamespace` to PodNamespace so leader election works in OutOfCluster mode ([#5404](https://github.com/kedacore/keda/issues/5404))
 - **AWS Scalers**: Ensure session tokens are included when instantiating AWS credentials ([#5156](https://github.com/kedacore/keda/issues/5156))
 - **Azure Event Hub Scaler**: Improve unprocessedEventThreshold calculation ([#4250](https://github.com/kedacore/keda/issues/4250))
 - **Azure Pipelines**: Prevent HTTP 400 errors due to `poolName` with spaces ([#5107](https://github.com/kedacore/keda/issues/5107))

diff --git a/cmd/operator/main.go b/cmd/operator/main.go
@@ -158,13 +158,14 @@ func main() {
 		Cache: ctrlcache.Options{
 			DefaultNamespaces: namespaces,
 		},
-		HealthProbeBindAddress: probeAddr,
-		PprofBindAddress:       profilingAddr,
-		LeaderElection:         enableLeaderElection,
-		LeaderElectionID:       "operator.keda.sh",
-		LeaseDuration:          leaseDuration,
-		RenewDeadline:          renewDeadline,
-		RetryPeriod:            retryPeriod,
+		HealthProbeBindAddress:  probeAddr,
+		PprofBindAddress:        profilingAddr,
+		LeaderElection:          enableLeaderElection,
+		LeaderElectionID:        "operator.keda.sh",
+		LeaderElectionNamespace: kedautil.GetPodNamespace(),
+		LeaseDuration:           leaseDuration,
+		RenewDeadline:           renewDeadline,
+		RetryPeriod:             retryPeriod,
 	})
 	if err != nil {
 		setupLog.Error(err, "unable to start manager")