Skip to content

Commit

Permalink
build(docker): Add 3.11 support to kedro-docker (#329)
Browse files Browse the repository at this point in the history
* Add 3.11 to version matrices

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Comment out plugins not of focus

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Drop Python upper bound

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Unpin precommit

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Bump pre-commit hook version

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Revert "Drop Python upper bound"

This reverts commit fd99930.

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Revert lint version

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Try unpin docker

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Fix typo

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Try upgrade pip

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Undo prev commit

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Temp change for faster CI

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Try something

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Try something else

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Include 3.11 in pyproject.toml

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Lint

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Change python version on docker

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Remove bandit pin airflow

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Try unpinned bandit

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Restore other files

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Restore other files pt 2

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add changes to RELEASE.md

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Apply suggestions from code review

Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>

---------

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>
  • Loading branch information
AhdraMeraliQB and SajidAlamQB authored Sep 7, 2023
1 parent 7557498 commit e4ea7c6
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/kedro-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
python-version: [ "3.7", "3.8", "3.9", "3.10" ]
python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11" ]
uses: ./.github/workflows/unit-tests.yml
with:
plugin: kedro-docker
Expand All @@ -40,7 +40,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest ]
python-version: [ "3.7", "3.8", "3.9", "3.10" ]
python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11" ]
uses: ./.github/workflows/e2e-tests.yml
with:
plugin: kedro-docker
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v3
# kedro-datasets is the only plugin that supports python 3.11
- name: Set up Python
uses: actions/setup-python@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ default_stages: [commit, manual]

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v2.2.3
rev: v2.4.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
Expand Down
2 changes: 1 addition & 1 deletion kedro-datasets/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def _collect_requirements(requires):
"Pillow~=9.0",
"plotly>=4.8.0, <6.0",
"polars[xlsx2csv, deltalake]~=0.18.0",
"pre-commit>=2.9.2, <3.0", # The hook `mypy` requires pre-commit version 2.9.2.
"pre-commit>=2.9.2, <3.0", # The hook `mypy` requires pre-commit version 2.9.2.
"pyarrow>=1.0; python_version < '3.11'",
"pyarrow>=7.0; python_version >= '3.11'", # Adding to avoid numpy build errors
"pylint>=2.5.2, <3.0",
Expand Down
1 change: 1 addition & 0 deletions kedro-docker/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
* Migrate all project metadata to static `pyproject.toml`.

## Major features and improvements
* Added support for Python 3.11

## Bug fixes and other changes

Expand Down
6 changes: 3 additions & 3 deletions kedro-docker/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ authors = [
{name = "Kedro"}
]
description = "Kedro-Docker makes it easy to package Kedro projects with Docker."
requires-python = ">=3.7, <3.11"
requires-python = ">=3.7"
license = {text = "Apache Software License (Apache 2.0)"}
dependencies = [
"anyconfig~=0.10.0", # not directly required, pinned by Snyk to avoid a vulnerability
Expand All @@ -24,8 +24,8 @@ Tracker = "https://github.com/kedro-org/kedro-plugins/issues"

[project.optional-dependencies]
test = [
"bandit>=1.6.2, <2.0",
"behave>=1.2.6, <2.0",
"bandit",
"behave",
"black~=22.0",
"docker",
"flake8>=3.5, <4.0",
Expand Down

0 comments on commit e4ea7c6

Please sign in to comment.