fix(datasets): Cleanup of dependency #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
ankatiyar
reviewed
Sep 3, 2024
| @@ -140,8 +144,15 @@ snowflake = ["kedro-datasets[snowflake-snowparktabledataset]"] | |||
| spark-deltatabledataset = ["kedro-datasets[spark-base,hdfs-base,s3fs-base,delta-base]"] | |||
| spark-sparkdataset = ["kedro-datasets[spark-base,hdfs-base,s3fs-base]"] | |||
| spark-sparkhivedataset = ["kedro-datasets[spark-base,hdfs-base,s3fs-base]"] | |||
| spark-sparkjdbcdataset = ["kedro-datasets[spark-base,hdfs-base,s3fs-base]"] | |||
| spark = ["kedro-datasets[spark-deltatabledataset]"] | |||
| spark-sparkjdbcdataset = ["kedro-datasets[spark-base]"] | |||
There was a problem hiding this comment.
does jbdbcdataset not need the hdfs-base or s3fs-base anymore?
There was a problem hiding this comment.
I believe JDBC is intended for relational databases and cannot be used with HDFS or S3FS?
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
harm-matthias-harms
pushed a commit
to harm-matthias-harms/kedro-plugins
that referenced
this pull request
Oct 1, 2024
* Update dependencies --------- Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Co-authored-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Signed-off-by: Harm Matthias Harms <matthias.harms@quis.de>
MinuraPunchihewa
pushed a commit
to MinuraPunchihewa/kedro-plugins
that referenced
this pull request
Oct 1, 2024
* Update dependencies --------- Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Co-authored-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Signed-off-by: Minura Punchihewa <minurapunchihewa17@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses issue #747.
Modifications:
dask-csvdataset.polars-genericdatasetas it currently doesn't exist.spark-sparkstreamingdataset.polarsandsparkgroups for consistency with other groups.hdfs-baseands3fs-basefromspark-sparkjdbcdatasetas they are not required. They were retained in other groups as they may be necessary depending on the data storage.Jinja2to<3.2.0for consistency with documentation requirements.tableson Windows, as it was relevant only for Python 3.8 and is no longer necessary.Checklist
RELEASE.mdfile