fix(telemetry): Set default identity value #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
ElenaKhaustova
requested review from
merelcht,
ankatiyar,
astrojuanlu,
DimedS and
noklam
noklam
approved these changes
Sep 10, 2024
DimedS
approved these changes
Sep 10, 2024
harm-matthias-harms
pushed a commit
to harm-matthias-harms/kedro-plugins
that referenced
this pull request
Oct 1, 2024
* Set default identity Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated test_before_command_run_anonymous Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fix lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Harm Matthias Harms <matthias.harms@quis.de>
MinuraPunchihewa
pushed a commit
to MinuraPunchihewa/kedro-plugins
that referenced
this pull request
Oct 1, 2024
* Set default identity Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated test_before_command_run_anonymous Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fix lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Minura Punchihewa <minurapunchihewa17@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #815
Development notes
The
identityparameter is mandatory when sending data to the heap. Not passing it or setting it to""orNonecauses the heap server to returnresponse code 400.The problem was that we used
identity=self._user_uuid. If we failed to read/generateuser_uuid, it was treated as an empty string, so passing it toidentitycausedresponse code 400when sending data to the server.To handle the above case
MISSING_USER_IDENTITYconstant was added, which is used as a default value for theidentityin caseuser_uuidis""orNone.Checklist
RELEASE.mdfile