Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets): Release kedro-datasets 5.0.0 #869

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

lrcouto
Copy link
Contributor

@lrcouto lrcouto commented Oct 7, 2024

Description

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Laura Couto <laurarccouto@gmail.com>
@lrcouto lrcouto linked an issue Oct 7, 2024 that may be closed by this pull request
@deepyaman
Copy link
Member

Just want to confirm—the intent is still to include the open PRs (#842, #812, other trivial open PRs) for release?

@lrcouto
Copy link
Contributor Author

lrcouto commented Oct 7, 2024

Just want to confirm—the intent is still to include the open PRs (#842, #812, other trivial open PRs) for release?

Will confirm that later today.

@lrcouto lrcouto marked this pull request as ready for review October 7, 2024 14:15
@lrcouto
Copy link
Contributor Author

lrcouto commented Oct 7, 2024

Just want to confirm—the intent is still to include the open PRs (#842, #812, other trivial open PRs) for release?

Will confirm that later today.

It would be nice if we could at least include #812 on this release since it's another breaking change.

@deepyaman
Copy link
Member

I'd argue #868 is also a trivial improvement that we should get in, unless there's a clear reason not to. I've pinged on #842 and will hopefully get the reviews soon; since it's gotten a number of user requests, and it's a new dataset (doesn't break any existing behavior), I would argue it could be done with fairly light review and get pretty immediate user feedback. 🤞

Most of my other PRs can wait. :)

@deepyaman
Copy link
Member

I've pinged on #842 and will hopefully get the reviews soon

Got some reviews, and made the minor updates. Still on track to go in. :)

lrcouto and others added 2 commits October 10, 2024 12:58
Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>
@tdhooghe
Copy link
Contributor

Happy to point PR #881 and update README.md and documentation accordingly, if you would want to merge it 🙂

@ElenaKhaustova
Copy link
Contributor

Happy to point PR #881 and update README.md and documentation accordingly, if you would want to merge it 🙂

This one will go to the next release 🙂

@lrcouto lrcouto merged commit 7b7f27c into main Oct 10, 2024
12 checks passed
@lrcouto lrcouto deleted the release/kedro-datasets/5.0.0 branch October 10, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release kedro-datasets
6 participants