Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump matplotlib test dependency #904

Merged
merged 2 commits into from
Oct 23, 2024
Merged

build: Bump matplotlib test dependency #904

merged 2 commits into from
Oct 23, 2024

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Oct 22, 2024

Description

It's been a while since I tried installing all kedro-dataset dependencies and when I did it failed on installing matplotlib. I bumped it to the same version as specified here: https://github.com/kedro-org/kedro-plugins/blob/main/kedro-datasets/pyproject.toml#L81 and was then able to install everything.

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht self-assigned this Oct 22, 2024
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht enabled auto-merge (squash) October 22, 2024 16:24
@merelcht merelcht merged commit bc2ad07 into main Oct 23, 2024
12 checks passed
@merelcht merelcht deleted the fix/dependency branch October 23, 2024 10:15
tdhooghe pushed a commit to tdhooghe/kedro-plugins that referenced this pull request Oct 24, 2024
* Bump matplotlib test dependency

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>

* Fix matplotlib test

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>

---------

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: tdhooghe <thomas_dhooghe@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants