Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

rebase blockifier #1566

Merged
merged 21 commits into from
Apr 25, 2024
Merged

rebase blockifier #1566

merged 21 commits into from
Apr 25, 2024

Conversation

tdelabro
Copy link
Collaborator

No description provided.

@tdelabro
rebase blockifier
ca1a7cf 
it compiles

madara runs again

wip

compiles again: only the tests left to fix

tests compile, time to fix them

remove all default-features option from Cargo.toml

new custom execution logic compiles, fewer test fail

pallet unitest green

all rpc tests ok

clippy
@tdelabro tdelabro force-pushed the rebase-latest-blockifier-single-commit branch from 1b06b3b to ca1a7cf Compare April 17, 2024 22:32
apoorvsadana
apoorvsadana reviewed Apr 20, 2024
View reviewed changes
crates/client/db/src/lib.rs Show resolved Hide resolved
crates/client/db/src/lib.rs Show resolved Hide resolved
crates/primitives/block/src/header.rs Show resolved Hide resolved
crates/client/mapping-sync/src/sync_blocks.rs Show resolved Hide resolved
crates/client/rpc-core/src/utils.rs Outdated Show resolved Hide resolved
crates/primitives/transactions/src/execution.rs Show resolved Hide resolved
crates/pallets/starknet/src/tests/re_execute_transactions.rs Show resolved Hide resolved
crates/pallets/starknet/src/transaction_validation.rs Show resolved Hide resolved
crates/primitives/simulations/src/lib.rs Show resolved Hide resolved
crates/primitives/transactions/src/from_broadcasted_transactions.rs Outdated Show resolved Hide resolved
@tdelabro tdelabro mentioned this pull request Apr 22, 2024
Closed
tdelabro
tdelabro commented Apr 22, 2024
View reviewed changes
Copy link
Collaborator Author

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finished reviewing every file. LGTM

EvolveArt
EvolveArt reviewed Apr 23, 2024
View reviewed changes
crates/client/db/src/lib.rs Show resolved Hide resolved
crates/client/l1-messages/src/contract.rs Show resolved Hide resolved
crates/client/l1-messages/src/worker.rs Outdated Show resolved Hide resolved
crates/client/mapping-sync/src/block_metrics.rs Show resolved Hide resolved
crates/client/rpc/src/events/mod.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/lib.rs Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/runtime/src/pallets.rs Show resolved Hide resolved
@tdelabro tdelabro force-pushed the rebase-latest-blockifier-single-commit branch from 992aecc to 3e99f89 Compare April 23, 2024 22:02
@tdelabro tdelabro merged commit d8a4441 into keep-starknet-strange:main Apr 25, 2024
15 of 16 checks passed
@tdelabro tdelabro mentioned this pull request Apr 26, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EvolveArt EvolveArt EvolveArt approved these changes

@apoorvsadana apoorvsadana apoorvsadana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdelabro @EvolveArt @apoorvsadana