-
Notifications
You must be signed in to change notification settings - Fork 295
feat: genesis loader #913
feat: genesis loader #913
Conversation
I left both the json and the yaml genesis files in the PR for now, with the goal to decide which one we keep. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
+ Coverage 42.04% 43.18% +1.13%
==========================================
Files 86 87 +1
Lines 10741 10669 -72
Branches 10741 10669 -72
==========================================
+ Hits 4516 4607 +91
+ Misses 5659 5493 -166
- Partials 566 569 +3
☔ View full report in Codecov by Sentry. |
fb092ff
to
7d3ec63
Compare
7d3ec63
to
f0b7252
Compare
f0b7252
to
ab55f2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
if we could add some scripts to easily compute the storage keys from madara repo directly that'd be really helpful I think (maybe an issue on starkli is better)
Adds a genesis loader to the starknet pallet, which allows to easily load a genesis from a yaml or json file.
What is the current behavior?
Genesis as to be hardcoded in the chain_spec.rs file from the node. This PR allows users to define their own genesis in a json.
What is the new behavior?
Does this introduce a breaking change?
Yes