-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve convertion errors and handle invalid ABI #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@whichqua please address @shamsasari comments before merging |
* fix: handle contract commitments for contract without data items Problem: reexecution panics when a contract doesnt have data items Solution: handle the edge case to prevent panics * fix: only one commitment return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This need further investigation in PAthfinder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…strange#387) * fix: improve convertion errors to provide more context * fix: better error handling and fix for invalid abi * fix: add tests for blocks, and minor fixes based on review * fix: handle contract commitments for contract without data items (keep-starknet-strange#388) * fix: handle contract commitments for contract without data items Problem: reexecution panics when a contract doesnt have data items Solution: handle the edge case to prevent panics * fix: only one commitment return * Revert "fix: handle contract commitments for contract without data items (keep-starknet-strange#388)" (keep-starknet-strange#394) This reverts commit 0c13f1c. --------- Co-authored-by: Herman Obst Demaestri <70286869+HermanObst@users.noreply.github.com>
Problem: During convertions between types from blockifier, starknet and cairolang classes, the errors returned are not consistent. This also led to finding an invalid api bug during convertion.
Solution:
ConvertionError
andRpcClientError
and handle them appropriately.None
when abi is not valid JSON.Issue Number: N/A
Type
Description
Breaking changes?