Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.9.5 #2392

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update to 1.9.5 #2392

wants to merge 2 commits into from

Conversation

varjolintu
Copy link
Member

Updates CHANGELOG, manifest files and offline translations for 1.9.5.

@droidmonkey
Copy link
Member

Is there a way to store the version string in one place and inject it where necessary during the build/load process?

@varjolintu
Copy link
Member Author

Is there a way to store the version string in one place and inject it where necessary during the build/load process?

The build script already supports a version parameter that can set the string to all manifest files. The problem is that the version needs to be updated to the repository anyway. For example, using the manifest V3 file for Chrome should always keep the version number up-to-date as well. So, I'll just need to make a better automation for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants