fix: Integration functionality stop on terminal kill #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
|
Great work! Works great with replay, please check on the record side |
|
also add semicolons in your files, will cause havoc later if not present |
khareyash05
changed the title
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
|
Looks good! ALso check if Keploy and the application has been stopped or not, this will 100 percent ensure that the functionality is completed working |
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
|
This is making, default running shell as bash, this isnt ideal,please look into the same |
|
if any terminal is open it is also closed please try to fix it |
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
|
Well done @ayush3160 |
khareyash05
assigned khareyash05 and ayush3160 and unassigned ayush3160 and khareyash05
shivamsouravjha
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix: fixed recording Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fix: fixed record command for zsh shell Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fix: fixed recording for all cases Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fix: fixed record script Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * minor change Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fix: test script Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fix: terminal disposing Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * added trap condition in zshScript Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fixed recording and testing Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * added exit in trap Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> --------- Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> Co-authored-by: Yash Khare <khareyash05@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes the behavior of recording when terminal is closed.
After recording test cases in zsh shell