-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Integration functionality stop on terminal kill #50
Conversation
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Great work! Works great with replay, please check on the record side |
also add semicolons in your files, will cause havoc later if not present |
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Looks good! ALso check if Keploy and the application has been stopped or not, this will 100 percent ensure that the functionality is completed working |
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
This is making, default running shell as bash, this isnt ideal,please look into the same |
if any terminal is open it is also closed please try to fix it |
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Signed-off-by: Ayush Sharma <kshitij3160@gmail.com>
Well done @ayush3160 |
* fix: fixed recording Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fix: fixed record command for zsh shell Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fix: fixed recording for all cases Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fix: fixed record script Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * minor change Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fix: test script Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fix: terminal disposing Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * added trap condition in zshScript Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * fixed recording and testing Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> * added exit in trap Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> --------- Signed-off-by: Ayush Sharma <kshitij3160@gmail.com> Co-authored-by: Yash Khare <khareyash05@gmail.com>
This pr fixes the behavior of recording when terminal is closed.
After recording test cases in zsh shell