Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keras-io to include KerasHub #1940

Merged
merged 12 commits into from
Oct 1, 2024
Merged

Update keras-io to include KerasHub #1940

merged 12 commits into from
Oct 1, 2024

Conversation

divyashreepathihalli
Copy link
Contributor

@divyashreepathihalli divyashreepathihalli commented Sep 27, 2024 •
edited
Loading

The PR contains the following changes

  • Adds KerasHub symbols
  • Adds in the docs for vision models that are added to kerasHub
  • Keeps KerasCV and KerasNLP sections on keras.io API symbols and guides - will be removed post official launch
  • Ports all of KerasNLP guides to use KerasHub
  • All of KerasNLP examples have be updated to KerasHub

fchollet
fchollet reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you look into the test failure?

3.709 FileNotFoundError: [Errno 2] No such file or directory: '/templates/guides/keras_nlp/upload.md'

examples/generative/ipynb/gpt2_text_generation_with_keras_hub.ipynb
@@ -642,7 +642,7 @@
"accelerator": "GPU",
"colab": {
"collapsed_sections": [],
"name": "gpt2_text_generation_with_kerasnlp",
"name": "gpt2_text_generation_with_kerashub",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any URLs are getting switched from kerasnlp to kerashub, we need to add redirects for them. Please add entries in the redirects/ directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates have been made to files in the redirects folder.

scripts/autogen.py Outdated Show resolved Hide resolved
@divyashreepathihalli
Copy link
Contributor Author

Thanks for the PR! Can you look into the test failure?

3.709 FileNotFoundError: [Errno 2] No such file or directory: '/templates/guides/keras_nlp/upload.md'

The test failure has been has been fixed

fchollet
fchollet approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fchollet fchollet merged commit 773263c into keras-team:master Oct 1, 2024
3 checks passed
@divyashreepathihalli divyashreepathihalli deleted the keras_hub_updates branch October 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

@MarkDaoust MarkDaoust Awaiting requested review from MarkDaoust MarkDaoust is a code owner

@pcoet pcoet Awaiting requested review from pcoet pcoet is a code owner

Assignees

@sachinprasadhs sachinprasadhs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@divyashreepathihalli @fchollet @sachinprasadhs @mattdangerw