Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding example for Customer Lifetime Value #1998

Merged
merged 10 commits into from
Dec 6, 2024

Conversation

praveenhosdrug123
Copy link
Contributor

Adding in the Tutobook for Customer Lifetime Value

Copy link

google-cla bot commented Nov 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 👍

examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@praveenhosdrug123 praveenhosdrug123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet - Reviewed and completed the changes suggested! For your review!

examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@praveenhosdrug123 praveenhosdrug123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the contigous Integration failure: Black Formatted

examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
@fchollet
Copy link
Contributor

Did you try running the code with JAX and PyTorch?

Copy link
Contributor Author

@praveenhosdrug123 praveenhosdrug123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet - Updated as per comments

@praveenhosdrug123

This comment was marked as outdated.

@fchollet
Copy link
Contributor

fchollet commented Dec 1, 2024

i have not yet ! I can look into JAX implementation of this code after this PR :)

Normally it should already be possible to run this code with JAX backend -- please try it

@praveenhosdrug123

This comment was marked as outdated.

@praveenhosdrug123

This comment was marked as resolved.

@fchollet
Copy link
Contributor

fchollet commented Dec 2, 2024

This worked fine before but now has the following issue, Would you be able to help me on this?

My best guess is that you need to reinstall / upgrade requests and possibly also kagglehub. This is not an issue with your code, it's an environment issue.

@praveenhosdrug123
Copy link
Contributor Author

praveenhosdrug123 commented Dec 2, 2024

This worked fine before but now has the following issue, Would you be able to help me on this?

My best guess is that you need to reinstall / upgrade requests and possibly also kagglehub. This is not an issue with your code, it's an environment issue.

I just tried it with reinstalling requests and kagglehub. It worked! Thank you so much! Please review and approve.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update -- please do a round of proofreading / polish on the text copy (you can use some LLM help for that if you want), and then please add the generated files by running the generation command (add_example)

examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
examples/generative/customer_lifetime_value.py Outdated Show resolved Hide resolved
@praveenhosdrug123
Copy link
Contributor Author

Thanks for the update -- please do a round of proofreading / polish on the text copy (you can use some LLM help for that if you want), and then please add the generated files by running the generation command (add_example)

Thank you, I have added the generated files in this PR. Appreciate all the help here!

Copy link
Contributor Author

@praveenhosdrug123 praveenhosdrug123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I have added the generated files in this PR. Appreciate all the help here!

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@fchollet fchollet merged commit d2ab57e into keras-team:master Dec 6, 2024
1 check passed
@praveenhosdrug123 praveenhosdrug123 deleted the clv_branch branch December 6, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants