add timeout to webhook sender

keratin · Jun 8, 2020 · 31c935b · 31c935b
1 parent e1b22d8
commit 31c935b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@ Based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## HEAD
 
+### Fixed
+
+* added a timeout to webhook sender
+
 ## 1.10.0
 
 ### Added

diff --git a/app/services/webhook_sender.go b/app/services/webhook_sender.go
@@ -38,8 +38,12 @@ func WebhookSender(destination *url.URL, values *url.Values, schedule []time.Dur
 		return fmt.Errorf("URL unconfigured")
 	}
 
+	c := &http.Client{
+		Timeout: 10 * time.Second,
+	}
+
 	err := retry(schedule, func() error {
-		res, err := http.PostForm(destination.String(), *values)
+		res, err := c.PostForm(destination.String(), *values)
 		if err == nil && res.StatusCode > 299 {
 			return fmt.Errorf("Status Code: %v", res.StatusCode)
 		}