[Build] Set Java Compiler's -release option instead of -source + -target #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasRentzCAU
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Did not know about this option yet, thanks.
However, the maven-javadoc-plugin version is intentionally set to Java 8, as a newer version causes the Javadoc plugin to fail, and as I recall in a spectacular way that I was not inclined to fix. Therefore this should be left at Java 8 as it still works as intended and, most importantly, makes publishing via ossrh possible.
HannesWell
force-pushed
the
specify-release
branch
from
828f7b3
to
212b6e6
Compare
Sure JavaDoc generation should of course work. Kept it as it is at 8. |
Using the --release option instead --source plus --target is more convenient (just one option) and more powerful (checks also that now newer Java API is used even if the executing JDK is newer).
HannesWell
force-pushed
the
specify-release
branch
from
212b6e6
to
344e114
Compare
|
See #220, something went wrong with this PR after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the --release option instead --source plus --target is more convenient (just one option) and more powerful (checks also that now newer Java API is used even if the executing JDK is newer).