Add fuzziness to softwrapping label manager. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a property that should be set on Labels and expand the softwrapping label manager to fuzzily check whether the next line could be placed on the current line. This reduces wasted whitespace.
NiklasRentzCAU
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
After the requested change, LGTM. Does what it says it does. The only awkward thing that could arise is that texts with a lot of lines could then be consistent in width with only the last line sticking out, but for such labels the property does not make much sense to use anyways.
Comment on lines
40
to
42
| /** Amount of line overhang that is permitted in percent of the effevtiveTargetWidth | ||
| * | ||
| * */ |
Correct spelling of fuzziness Remove superfluous comment Add check to only execute fuzzy code when it would have an effect
|
PR is now dependent on this PR in ELK: eclipse/elk#1082 |
Eddykasp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a property that should be set on Labels and expand the softwrapping label manager to fuzzily check whether the next line could be placed on the current line.
This reduces wasted whitespace.