Poi icon scaling #178
Merged
Poi icon scaling #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1kPLV
commented
Sep 22, 2023
| if (poiIcon instanceof HTMLElement) { | ||
| // set the height and width using inline styles. | ||
| // this will probably make this component much more fragile than it needs to be... | ||
| poiIcon.style.width = poiIcon.style.height = `${poiIconSideLength}rem`; |
There was a problem hiding this comment.
React does not recommend to dynamically inject a style-tag as this could impact performance. Therefore this is using inline-styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically make POI icons smaller if the map is zoomed out. This isn't the cleanest possible solution, but it works.