chore: use constant for the default major_version 1 for decision message

kindredgroup · Sep 9, 2024 · 1e4b0ad · 1e4b0ad
1 parent bb8af2e
commit 1e4b0ad
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/packages/talos_certifier/src/model/decision_message.rs b/packages/talos_certifier/src/model/decision_message.rs
@@ -7,6 +7,8 @@ use crate::certifier::Outcome;
 
 use super::{candidate_message::CandidateMessage, metrics::TxProcessingTimeline};
 
+pub const DEFAULT_DECISION_MESSAGE_VERSION: u64 = 1_u64;
+
 #[derive(Debug, Serialize, Deserialize, Clone, Eq, PartialEq)]
 pub enum Decision {
     #[serde(rename = "committed")]

diff --git a/packages/talos_certifier/src/model/mod.rs b/packages/talos_certifier/src/model/mod.rs
@@ -5,4 +5,4 @@ pub mod delivery_order;
 pub mod metrics;
 
 pub use candidate_message::{CandidateMessage, CandidateReadWriteSet};
-pub use decision_message::{Decision, DecisionMessage, DecisionMessageTrait};
+pub use decision_message::{Decision, DecisionMessage, DecisionMessageTrait, DEFAULT_DECISION_MESSAGE_VERSION};
diff --git a/packages/talos_certifier/src/services/decision_outbox_service.rs b/packages/talos_certifier/src/services/decision_outbox_service.rs
@@ -9,6 +9,7 @@ use tokio::sync::mpsc;
 
 use crate::core::ServiceResult;
 use crate::model::decision_headers::{DecisionCertHeaders, DecisionHeaderBuilder, DecisionMetaHeaders};
+use crate::model::DEFAULT_DECISION_MESSAGE_VERSION;
 use crate::{
     core::{DecisionOutboxChannelMessage, System, SystemService},
     errors::{SystemServiceError, SystemServiceErrorKind},
@@ -114,7 +115,7 @@ impl SystemService for DecisionOutboxService {
             } = decision_channel_message;
             tokio::spawn({
                 let decision_headers = DecisionHeaderBuilder::with_additional_headers(headers.into()).add_meta_headers(DecisionMetaHeaders::new(
-                    1_u64, // major version of decision message
+                    DEFAULT_DECISION_MESSAGE_VERSION, // major version of decision message
                     self.system.name.clone(),
                     None,
                 ));