Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohort Banking example with SDK #63

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

fmarek-kindred
Copy link
Contributor

No description provided.

@fmarek-kindred fmarek-kindred marked this pull request as ready for review July 26, 2023 06:01
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 22.82% and project coverage change: -8.86% ⚠️

Comparison is base (9c43ba7) 65.03% compared to head (cc6f37f) 56.18%.

❗ Current head cc6f37f differs from pull request most recent head c00c0fe. Consider uploading reports for the commit c00c0fe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   65.03%   56.18%   -8.86%     
==========================================
  Files          90      112      +22     
  Lines        4814     6089    +1275     
==========================================
+ Hits         3131     3421     +290     
- Misses       1683     2668     +985     
Files Changed Coverage Δ
packages/cohort/src/bank_api.rs 0.00% <0.00%> (ø)
packages/cohort/src/bin/preload_db.rs 2.12% <0.00%> (ø)
packages/cohort/src/core.rs 89.47% <ø> (ø)
packages/cohort/src/delay_controller.rs 0.00% <ø> (ø)
...ges/cohort/src/examples_support/queue_processor.rs 0.00% <ø> (ø)
packages/cohort/src/lib.rs 100.00% <ø> (ø)
...ges/cohort/src/replicator/utils/installer_utils.rs 0.00% <0.00%> (ø)
packages/cohort/src/snapshot_api.rs 0.00% <0.00%> (ø)
packages/cohort_banking/src/app.rs 0.00% <0.00%> (ø)
...kages/cohort_banking/src/callbacks/oo_installer.rs 0.00% <0.00%> (ø)
... and 28 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gk-kindred gk-kindred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Love how simple the SDK package is. Good work

@fmarek-kindred fmarek-kindred merged commit 2018d60 into master Jul 31, 2023
2 checks passed
@fmarek-kindred fmarek-kindred deleted the feature/cohort_banking_use_sdk branch July 31, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants