feat: Introduce opentel metrics to cohort sdk and banking example. #65
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 61.84% 59.30% -2.54%
==========================================
Files 89 93 +4
Lines 4888 5104 +216
==========================================
+ Hits 3023 3027 +4
- Misses 1865 2077 +212
☔ View full report in Codecov by Sentry. |
| once_cell = { version = "1.18.0"} |
There was a problem hiding this comment.
This is not required any more, could you remove it?
| @@ -93,6 +94,8 @@ impl ControlledRateLoadGenerator { | |||
| } | |||
| } | |||
|
|
|||
| tx_output.close(); | |||
There was a problem hiding this comment.
Still a bit confused as to why drop was not working while exiting the generator. But if explicit close is working that should be good.
There was a problem hiding this comment.
Because its arc'ed?
There was a problem hiding this comment.
I did check that during the review, Arc should drop the inner value if the reference count goes to 0.
And in our use case, we don't clone it. So the reference count is 1 which on exiting will become 0, and therefore drop the inner value.
No description provided.