-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update Button page #3115
Merged
Merged
feat: update Button page #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvenon
force-pushed
the
feat/button-page-updates
branch
from
September 24, 2021 14:42
28ffb43
to
e830c70
Compare
Deploying with Cloudflare Pages
|
Size Change: 0 B Total Size: 475 kB ℹ️ View Unchanged
|
silvenon
force-pushed
the
feat/button-page-updates
branch
from
September 24, 2021 14:54
e830c70
to
85a5eff
Compare
Temporarily stop remark from failing when checking links because some headings are within components, so remark-validate-links cannot check those, and it doesn't appear to offer disable comments currently. remarkjs/remark-validate-links#18
silvenon
force-pushed
the
feat/button-page-updates
branch
from
September 24, 2021 15:28
85a5eff
to
45a88fc
Compare
mainframev
previously requested changes
Sep 27, 2021
Also some small things here:
|
silvenon
dismissed
mainframev’s stale review
September 28, 2021 14:13
These changes have been resolved. Unfortunately there's no time for another review, so I'll merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to temporarily stop remark from failing when checking local links because some headings are inside components, and there doesn't appear to be a way to disable remark-validate-links with
<!-- lint disable validate-links -->
comments becauseremark-validate-links
is a remark plugin, not remark-lint. remarkjs/remark-validate-links#18Storybook: https://orbit-silvenon-feat-button-page-updates.surge.sh