support client certificates when communicating with REQ_URL #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Syed Nihal <syed.nihal@nokia.com>
|
Hi @ChristianGeie, could you please let me know if this is an acceptable feature by the community? I shall add some tests related to it. |
| # If method is not provided use GET as default | ||
| if method == "GET" or not method: | ||
| res = r.get("%s" % url, auth=auth, timeout=REQ_TIMEOUT, verify=REQ_TLS_VERIFY) | ||
| res = r.get("%s" % url, cert=cert, auth=auth, timeout=REQ_TIMEOUT, verify=REQ_TLS_VERIFY) |
There was a problem hiding this comment.
Yes, the default value is None for cert if not specified.
Reference: https://docs.python-requests.org/en/latest/_modules/requests/sessions/#Session
|
please add some tests :-) |
Signed-off-by: wasim-nihal <sswasim64@gmail.com>
Hi @tomrk-esteam8 / @ChristianGeie, I have added some tests related to this feature. Could you please take a look? |
Signed-off-by: wasim-nihal <sswasim64@gmail.com>
Signed-off-by: wasim-nihal <sswasim64@gmail.com>
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #334