-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake8 check #263
Comments
@refeed Why not, would be be able to make a PR to introduce it? |
@refeed Alright, I'm gonna make a PR for it |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
is it still open if then i would like to work on it. |
@HimanshuMahto yes you can |
Is this issue still open? Because I want to work on it. |
The issue is still open. But I strongly suggest that @Rayan-Rasheed and @HimanshuMahto discuss together before doing both the same work. |
is this issue still available ? |
Yes. |
is this issue still open? |
Yes, I still want to have a formalism check of the Python code... but we should probably revide a bit the requirements. @benoit74 @rgaudin Could you please tell what should be respected to respect our standards? Maybe you could also point to a place where the check workflow ismproperly implemented already? |
kiwix-build
mainly comprises of Python codes, I think it'd be nice if this repository had a flake8 (which checks for codestyle and possible errors and bug (such as unused var, etc)) check in its Travis-CI.The text was updated successfully, but these errors were encountered: