Skip to content

Commit

Permalink
Add flake8 check to Travis-CI matrix
Browse files Browse the repository at this point in the history
Closes kiwix#263
  • Loading branch information
refeed committed Mar 26, 2019
1 parent 250c20c commit 92c6c55
Show file tree
Hide file tree
Showing 3 changed files with 80 additions and 19 deletions.
32 changes: 20 additions & 12 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ if: type != push OR tag IS present
before_install:
- PATH=$PATH:${HOME}/bin:${HOME}/.local/bin
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then PATH=$PATH:$(brew --prefix)/opt/gettext/bin; fi
- '[ -n "$encrypted_eba2f7543984_iv" ] && openssl aes-256-cbc
- echo ${TRAVIS_PULL_REQUEST}
- '[ -n "$encrypted_eba2f7543984_iv" ] && [ "${TRAVIS_PULL_REQUEST}" == "false" ] && openssl aes-256-cbc
-K $encrypted_eba2f7543984_key -iv $encrypted_eba2f7543984_iv
-in travis/travisci_builder_id_key.enc -out travis/travisci_builder_id_key -d'
- chmod 600 travis/travisci_builder_id_key
Expand All @@ -30,21 +31,26 @@ cache:
install: if [[ $TRAVIS_OS_NAME != "linux" || $DESKTOP_ONLY != 1 ]]; then travis/install_extra_deps.sh; fi
script:
- |
if [[ $TRAVIS_OS_NAME = "linux" && $DESKTOP_ONLY == 1 ]]
if [[ $TEST_SUITE = "flake8_check" ]]
then
if [[ $PLATFORM = "flatpak" ]]
then
docker build -t kiwix/build -f travis/Dockerfile_flatpak .
else
docker build -t kiwix/build -f travis/Dockerfile .
fi
docker run -e PLATFORM -e NIGHTLY_DATE -e TRAVIS_EVENT_TYPE -e DESKTOP_ONLY -e TRAVIS_TAG --device /dev/fuse --cap-add ALL --privileged kiwix/build
flake8 .
else
if [[ $TRAVIS_OS_NAME = "linux" ]]
if [[ $TRAVIS_OS_NAME = "linux" && $DESKTOP_ONLY == 1 ]]
then
python3.5 travis/compile_all.py
if [[ $PLATFORM = "flatpak" ]]
then
docker build -t kiwix/build -f travis/Dockerfile_flatpak .
else
docker build -t kiwix/build -f travis/Dockerfile .
fi
docker run -e PLATFORM -e NIGHTLY_DATE -e TRAVIS_EVENT_TYPE -e DESKTOP_ONLY -e TRAVIS_TAG --device /dev/fuse --cap-add ALL --privileged kiwix/build
else
python3 travis/compile_all.py
if [[ $TRAVIS_OS_NAME = "linux" ]]
then
python3.5 travis/compile_all.py
else
python3 travis/compile_all.py
fi
fi
fi
after_failure: travis/upload_all_log.sh
Expand Down Expand Up @@ -145,6 +151,8 @@ matrix:
os: osx
- env: PLATFORM="iOS_i386"
os: osx
- env: TEST_SUITE="flake8_check"
os: osx

notifications:
irc:
Expand Down
46 changes: 46 additions & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
[flake8]
ignore =
E201, # whitespace after '{'
E202, # whitespace before '}'
E501, # line too long
E128, # continuation line under-indented for visual indent
E226, # missing whitespace around arithmetic operator
E126, # continuation line over-indented for hanging indent
E203, # whitespace before ':'
E111, # indentation is not a multiple of four
E261, # at least two spaces before inline comment
E124, # closing bracket does not match visual indentation
E731, # do not assign a lambda expression, use a def
E401, # multiple imports on one line
E302, # expected 2 blank lines, found 1
W503, # line break before binary operator
E231, # missing whitespace after ':'
E303, # too many blank lines (2)
E302, # expected 2 blank lines, found 1
E305, # expected 2 blank lines after class or function definition, found 1
F401, # 'X' imported but unused
F821, # undefined name 'X'
E228, # missing whitespace around modulo operator
E999, # SyntaxError: invalid syntax
E225, # missing whitespace around operator
F403, # 'from .base import *' used; unable to detect undefined names
W391, # blank line at end of file
E122, # continuation line missing indentation or outdented
E251, # unexpected spaces around keyword / parameter equals
E713, # test for membership should be 'not in'
E722, # do not use bare except'
E129, # visually indented line with same indent as next logical line
E301, # expected 1 blank line, found 0
E121, # continuation line under-indented for hanging indent
E123, # closing bracket does not match indentation of opening bracket's line
E127, # continuation line over-indented for visual indent
E222, # multiple spaces after operator
E265, # block comment should start with '# '
F811, # redefinition of unused X
E222, # multiple spaces after operator
E117, # over-indented
W504, # line break after binary operator
F405, # 'X' may be undefined, or defined from star imports: X
F841, # local variable 'tlc' is assigned to but never used
W605, # invalid escape sequence '\|'
F402, # import 'X' from line X shadowed by loop variable
21 changes: 14 additions & 7 deletions travis/install_extra_deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,16 @@ set -e

if [[ "$TRAVIS_OS_NAME" == "osx" ]]
then
pip3 install pillow
pip3 install .
if [[ "$TEST_SUITE" == "flake8_check" ]]
then
pip3 install flake8
else
pip3 install pillow
pip3 install .

wget https://github.com/ninja-build/ninja/releases/download/v1.8.2/ninja-mac.zip
unzip ninja-mac.zip ninja
wget https://github.com/ninja-build/ninja/releases/download/v1.8.2/ninja-mac.zip
unzip ninja-mac.zip ninja
fi
else
wget https://bootstrap.pypa.io/get-pip.py
python3.5 get-pip.py --user
Expand All @@ -21,6 +26,8 @@ else
unzip ninja-linux.zip ninja
fi

mkdir -p $HOME/bin
cp ninja $HOME/bin

if [[ "$TEST_SUITE" != "flake8_check" ]]
then
mkdir -p $HOME/bin
cp ninja $HOME/bin
fi

0 comments on commit 92c6c55

Please sign in to comment.