Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake8 check #263

Open
refeed opened this issue Oct 29, 2018 · 12 comments · May be fixed by #305
Open

Add flake8 check #263

refeed opened this issue Oct 29, 2018 · 12 comments · May be fixed by #305
Labels
enhancement good first issue

Comments

@refeed
Copy link

refeed commented Oct 29, 2018

kiwix-build mainly comprises of Python codes, I think it'd be nice if this repository had a flake8 (which checks for codestyle and possible errors and bug (such as unused var, etc)) check in its Travis-CI.
@kelson42
Copy link
Contributor

@refeed Why not, would be be able to make a PR to introduce it?

@refeed
Copy link
Author

refeed commented Mar 24, 2019

@refeed Alright, I'm gonna make a PR for it

refeed added a commit to refeed/kiwix-build that referenced this issue Mar 24, 2019
@refeed
Add flake8 check to Travis-CI matrix
5be6f26 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 24, 2019
@refeed
Add flake8 check to Travis-CI matrix
405c5e5 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 24, 2019
@refeed
Add flake8 check to Travis-CI matrix
7ac355a 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 24, 2019
@refeed
Add flake8 check to Travis-CI matrix
605d2d3 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 24, 2019
@refeed
Add flake8 check to Travis-CI matrix
3f22452 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 24, 2019
@refeed
Add flake8 check to Travis-CI matrix
df811fd 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 24, 2019
@refeed
Add flake8 check to Travis-CI matrix
686341a 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 24, 2019
@refeed
Add flake8 check to Travis-CI matrix
8b043e4 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 25, 2019
@refeed
Add flake8 check to Travis-CI matrix
73b06c8 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 25, 2019
@refeed
Add flake8 check to Travis-CI matrix
419aac6 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 25, 2019
@refeed
Add flake8 check to Travis-CI matrix
b3727fa 
Closes kiwix#263
@refeed refeed linked a pull request Mar 25, 2019 that will close this issue
Open
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 26, 2019
@refeed
Add flake8 check to Travis-CI matrix
95001a7 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 26, 2019
@refeed
Add flake8 check to Travis-CI matrix
7a011d0 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 26, 2019
@refeed
Add flake8 check to Travis-CI matrix
92c6c55 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 26, 2019
@refeed
Add flake8 check to Travis-CI matrix
e7b3b0e 
Closes kiwix#263
refeed added a commit to refeed/kiwix-build that referenced this issue Mar 26, 2019
@refeed
Add flake8 check to Travis-CI matrix
d593a31 
Closes kiwix#263
@stale
Copy link

stale bot commented Dec 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Dec 14, 2019
@HimanshuMahto
Copy link

is it still open if then i would like to work on it.

@stale stale bot removed the stale label Mar 3, 2023
@kelson42
Copy link
Contributor

kelson42 commented Mar 4, 2023

@HimanshuMahto yes you can

@Rayan-Rasheed
Copy link

Is this issue still open? Because I want to work on it.

@kelson42
Copy link
Contributor

kelson42 commented Mar 7, 2023

@mgautierfr ?

@mgautierfr
Copy link
Member

The issue is still open. But I strongly suggest that @Rayan-Rasheed and @HimanshuMahto discuss together before doing both the same work.
On my side I don't care about who does it. I will review the first PR coming (and accept the first acceptable one). I don't which to review to almost identical PR.

@Vishnurr2k01
Copy link

is this issue still available ?

@mgautierfr
Copy link
Member

Yes.

@Anandbrewery
Copy link

is this issue still open?
i am interested to contribute for this

@kelson42
Copy link
Contributor

Yes, I still want to have a formalism check of the Python code... but we should probably revide a bit the requirements. @benoit74 @rgaudin Could you please tell what should be respected to respect our standards? Maybe you could also point to a place where the check workflow ismproperly implemented already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add flake8 check to Travis-CI matrix refeed/kiwix-build
7 participants
@mgautierfr @kelson42 @refeed @Vishnurr2k01 @HimanshuMahto @Rayan-Rasheed @Anandbrewery