dev: work on comments from fred

crates/hive-utils/src/hive/genesis.rs

@@ -51,8 +51,8 @@ pub struct HiveGenesisConfig {
 
 impl HiveGenesisConfig {
     pub fn from_file(path: &str) -> Result<Self> {
-        let hive_genesis_file = File::open(path).unwrap();
-        Ok(serde_json::from_reader(hive_genesis_file).unwrap())
+        let hive_genesis_file = File::open(path)?;
+        Ok(serde_json::from_reader(hive_genesis_file)?)
     }
 }
 
@@ -226,8 +226,8 @@ pub async fn serialize_hive_to_madara_genesis_config(
     });
 
     let combined_genesis_file =
-        File::options().create_new(true).write(true).append(true).open(combined_genesis_path).unwrap();
-    // Serialize the loader to a string and then write to a file
+        File::options().create_new(true).write(true).append(false).open(combined_genesis_path).unwrap();
+    // Serialize the loader to a file
     serde_json::to_writer_pretty(combined_genesis_file, &madara_loader)?;
 
     Ok(())

crates/test-utils/src/bin/dump-katana.rs

@@ -1,5 +1,6 @@
 use std::collections::HashMap;
 use std::fs::File;
+use std::path::PathBuf;
 
 use ethers::abi::Token;
 use git2::{Repository, SubmoduleIgnore};
@@ -38,9 +39,17 @@ async fn main() {
 
         // Dump the state
         std::fs::create_dir_all(".katana/").expect("Failed to create Kakata dump dir");
-        let katana_dump_file =
-            File::options().create_new(true).read(true).write(true).append(true).open(".katana/dump.json").unwrap();
-        serde_json::to_writer(katana_dump_file, &dump_state);
+
+        let katana_dump_path = String::from(".katana/dump.json");
+        let katana_dump_file = File::options()
+            .create_new(true)
+            .read(true)
+            .write(true)
+            .append(false)
+            .open(katana_dump_path)
+            .expect(format!("Failed to open file {}", katana_dump_path));
+        serde_json::to_writer_pretty(katana_dump_file, &dump_state)
+            .expect(format!("Failed to write to the file {}", katana_dump_path));
 
         let deployer_account = DeployerAccount {
             address: test_context.client().deployer_account().address(),