-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: refactor kakarot_rpc_core::test_utils to a kakarot_test_utils crate #553
Conversation
2d16772
to
acd1869
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment then looks good
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
===========================================
+ Coverage 23.17% 72.80% +49.63%
===========================================
Files 9 45 +36
Lines 1247 4060 +2813
===========================================
+ Hits 289 2956 +2667
- Misses 958 1104 +146
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Thanks for the refactor! Now we start cleaning these utils :) |
Switch from self hosted runners to managed runners
Time spent on this PR:
Resolves: #554
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
The kakarot_rpc_core::test_utils has been refactored to a new trait
kakarot_test_utils
Does this introduce a breaking change?