Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: refactor kakarot_rpc_core::test_utils to a kakarot_test_utils crate #553

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

bajpai244
Copy link
Contributor

@bajpai244 bajpai244 commented Sep 12, 2023

Time spent on this PR:

Resolves: #554

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

The kakarot_rpc_core::test_utils has been refactored to a new trait kakarot_test_utils

Does this introduce a breaking change?

  • Yes
  • No

crates/core/src/client/mod.rs Outdated Show resolved Hide resolved
crates/test-utils/Cargo.toml Show resolved Hide resolved
Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment then looks good

crates/test-utils/Cargo.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 83.43% and project coverage change: +49.63% 🎉

Comparison is base (71506a8) 23.17% compared to head (773ff31) 72.80%.
Report is 216 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #553       +/-   ##
===========================================
+ Coverage   23.17%   72.80%   +49.63%     
===========================================
  Files           9       45       +36     
  Lines        1247     4060     +2813     
===========================================
+ Hits          289     2956     +2667     
- Misses        958     1104      +146     
Files Changed Coverage Δ
crates/core/src/mock/serde.rs 0.00% <0.00%> (ø)
crates/core/src/models/transaction.rs 93.63% <ø> (ø)
crates/core/src/models/transaction_receipt.rs 97.02% <ø> (ø)
crates/eth-rpc/src/api/alchemy_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/eth_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/net_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/web3_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/config.rs 100.00% <ø> (ø)
crates/eth-rpc/src/lib.rs 93.33% <ø> (ø)
crates/eth-rpc/src/main.rs 0.00% <ø> (ø)
... and 35 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@greged93
Copy link
Contributor

Thanks for the refactor! Now we start cleaning these utils :)

@ClementWalter ClementWalter added this pull request to the merge queue Sep 12, 2023
Merged via the queue into kkrt-labs:main with commit 46cddc6 Sep 12, 2023
9 checks passed
anukkrit149 pushed a commit to karnotxyz/kakarot-rpc that referenced this pull request Aug 9, 2024
Switch from self hosted runners to managed runners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: refactor kakarot_rpc_core::test_utils to kakarot_test_utils crate
3 participants