Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: refactor hive-utils crate and kakarot_rpc::test_utils to test_utils crate #558

Merged

Conversation

bajpai244
Copy link
Contributor

Resolves: #547

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

The hive-utils crate and kakarot_rpc::test_utils have been refactored to a seperate test_utils crate.

Does this introduce a breaking change?

  • Yes
  • No

@bajpai244 bajpai244 force-pushed the dev/move-hive-utils-to-test-utils branch from a895199 to 7e08249 Compare September 12, 2023 14:28
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 83.43% and project coverage change: +49.61% 🎉

Comparison is base (71506a8) 23.17% compared to head (7e08249) 72.78%.
Report is 220 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #558       +/-   ##
===========================================
+ Coverage   23.17%   72.78%   +49.61%     
===========================================
  Files           9       45       +36     
  Lines        1247     4061     +2814     
===========================================
+ Hits          289     2956     +2667     
- Misses        958     1105      +147     
Files Changed Coverage Δ
crates/core/src/mock/serde.rs 0.00% <0.00%> (ø)
crates/core/src/models/transaction.rs 93.63% <ø> (ø)
crates/core/src/models/transaction_receipt.rs 97.02% <ø> (ø)
crates/eth-rpc/src/api/alchemy_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/eth_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/net_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/web3_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/config.rs 100.00% <ø> (ø)
crates/eth-rpc/src/lib.rs 93.33% <ø> (ø)
crates/eth-rpc/src/main.rs 0.00% <ø> (ø)
... and 35 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementWalter ClementWalter added this pull request to the merge queue Sep 14, 2023
Merged via the queue into kkrt-labs:main with commit a299d79 Sep 14, 2023
9 checks passed
anukkrit149 pushed a commit to karnotxyz/kakarot-rpc that referenced this pull request Aug 9, 2024
<!--- Please provide a general summary of your changes in the title
above -->
Updates necessary dependencies to be able to interact with the current
version of Starknet deployed on the testnet (v0.11).

<!-- Give an estimate of the time you spent on this PR in terms of work
days. Did you spend 0.5 days on this PR or rather 2 days? -->

Time spent on this PR: 0.75 day

## Pull request type

<!-- Please try to limit your pull request to one type, submit multiple
pull requests if needed. -->

Please check the type of change your PR introduces:

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [x] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?
The current dependencies are outdated and prevent the interaction with
Starknet 0.11 deployed on the testnet.

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Resolves kkrt-labs#558 

## What is the new behavior?

<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Starknet-py updated to version 0.15 which fixes failing interactions
with the testnet.
- Cairo-lang updated to the latest version 0.11
- Replace py-evm by blake2b-py 

## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: refactor all test utils to a seperate crate test_utils
2 participants