Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump lib/madara from d16139c to 5e24aba #564

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 13, 2023

Bumps lib/madara from d16139c to 5e24aba.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [lib/madara](https://github.com/keep-starknet-strange/madara) from `d16139c` to `5e24aba`.
- [Release notes](https://github.com/keep-starknet-strange/madara/releases)
- [Commits](keep-starknet-strange/madara@d16139c...5e24aba)

---
updated-dependencies:
- dependency-name: lib/madara
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Change in project dependencies. label Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 83.43% and project coverage change: +49.63% 🎉

Comparison is base (71506a8) 23.17% compared to head (eb8154c) 72.80%.
Report is 221 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #564       +/-   ##
===========================================
+ Coverage   23.17%   72.80%   +49.63%     
===========================================
  Files           9       45       +36     
  Lines        1247     4060     +2813     
===========================================
+ Hits          289     2956     +2667     
- Misses        958     1104      +146     
Files Changed Coverage Δ
crates/core/src/mock/serde.rs 0.00% <0.00%> (ø)
crates/core/src/models/transaction.rs 93.63% <ø> (ø)
crates/core/src/models/transaction_receipt.rs 97.02% <ø> (ø)
crates/eth-rpc/src/api/alchemy_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/eth_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/net_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/web3_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/config.rs 100.00% <ø> (ø)
crates/eth-rpc/src/lib.rs 93.33% <ø> (ø)
crates/eth-rpc/src/main.rs 0.00% <ø> (ø)
... and 35 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikix Eikix added this pull request to the merge queue Sep 14, 2023
Merged via the queue into main with commit c766cd0 Sep 14, 2023
9 checks passed
@Eikix Eikix deleted the dependabot/submodules/lib/madara-5e24aba branch September 14, 2023 09:39
anukkrit149 pushed a commit to karnotxyz/kakarot-rpc that referenced this pull request Aug 9, 2024
Time spent on this PR: 1 day

## Pull request type

Please check the type of change your PR introduces:

- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

Resolves kkrt-labs#555 

## What is the new behavior?

Starknet account nonce is validated against EVM tx nonce

## Other information

We need to remove the `nonce` `storage_var` and use the `TxInfo`
instead.
Consequently created kkrt-labs/kakarot#616

---------

Co-authored-by: Clément Walter <clement0walter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Change in project dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant