fix: split integration test files #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
===========================================
+ Coverage 23.17% 72.80% +49.63%
===========================================
Files 9 45 +36
Lines 1247 4060 +2813
===========================================
+ Hits 289 2956 +2667
- Misses 958 1104 +146
☔ View full report in Codecov by Sentry. |
ClementWalter
approved these changes
Sep 14, 2023
anukkrit149
pushed a commit
to karnotxyz/kakarot-rpc
that referenced
this pull request
Aug 9, 2024
<!--- Please provide a general summary of your changes in the title above --> An error caused the deployment script to crash when missing an evm private key in the .env file. <!-- Give an estimate of the time you spent on this PR in terms of work days. Did you spend 0.5 days on this PR or rather 2 days? --> Time spent on this PR: N/A ## Pull request type <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Error in script prevents CI deployment of contracts. Resolves N/A ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Scripts are updated in order to allow deployment with missing evm private key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the integration tests into different files for easier navigation.
Time spent on this PR: 0.1 day
Resolves: #544
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
The integrationt tests are split into different files in order to allow for easier navigation.
Does this introduce a breaking change?