dev: remove reduntant assigment of test_environment variable
#568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
===========================================
+ Coverage 23.17% 72.78% +49.61%
===========================================
Files 9 45 +36
Lines 1247 4061 +2814
===========================================
+ Hits 289 2956 +2667
- Misses 958 1105 +147
☔ View full report in Codecov by Sentry. |
anukkrit149
pushed a commit
to karnotxyz/kakarot-rpc
that referenced
this pull request
Aug 9, 2024
…-labs#569) Fix the address to be hex inside the fund_address function when the input is of type int and the network is devnet. ## Pull request type: fix Please check the type of change your PR introduces: - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? Upon investigating kkrt-labs#568 , I found that the following function calls are involved: - deploy_and_fund_evm_address - fund_address When we investigate fund_address, the following code snippet is where the error comes from: ```python address = int(address, 16) if isinstance(address, str) else address amount = amount * 1e18 if NETWORK == "devnet": response = requests.post( f"{GATEWAY_CLIENT.net}/mint", json={"address": address, "amount": amount} ) if response.status_code != 200: logger.error(f"Cannot mint token to {address}: {response.text}") logger.info(f"{amount / 1e18} ETH minted to {address}") ``` the address is expected to be a hex string, and since it is not we get the error described in kkrt-labs#568. Resolves <kkrt-labs/kakarot#568> ## What is the new behavior? In the new behavior, if the type is *int*, then we call **hex()** to it, to convert it into a hex string. Co-authored-by: Harsh Bajpai <harshbajpai@Harshs-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #567
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
Does this introduce a breaking change?