fix: replace Orientation input enum with a string set type

klippa-app · Aug 16, 2023 · 101bdb2 · 101bdb2
1 parent 1419be9
commit 101bdb2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/projects/klippa/ngx-enhancy-forms/src/lib/elements/radio/radio.component.html b/projects/klippa/ngx-enhancy-forms/src/lib/elements/radio/radio.component.html
@@ -1,4 +1,4 @@
-<div class="componentContainer" [ngClass]="{'verticallyOriented': orientation === Orientation.COLUMN, 'horizontallyOriented': orientation === Orientation.ROW}">
+<div class="componentContainer" [ngClass]="{'verticallyOriented': orientation === 'column', 'horizontallyOriented': orientation === 'row'}">
 	<ng-container *ngFor="let option of options">
 		<button class="optionContainer"
 			[ngClass]="{classic: variant === 'classic', button: variant === 'button', isSelected: innerValue === option.id}"

diff --git a/projects/klippa/ngx-enhancy-forms/src/lib/elements/radio/radio.component.ts b/projects/klippa/ngx-enhancy-forms/src/lib/elements/radio/radio.component.ts
@@ -2,10 +2,8 @@ import { Component, Input} from '@angular/core';
 import { NG_VALUE_ACCESSOR } from '@angular/forms';
 import { ValueAccessorBase } from '../value-accessor-base/value-accessor-base.component';
 
-export enum Orientation {
-	COLUMN = 'column',
-	ROW = 'row'
-}
+export type RadioVariant = 'classic' | 'button';
+export type RadioOrientation = 'column' | 'row';
 export type RadioOptions = Array<RadioOption>;
 export type RadioOption = {
 	id: any;
@@ -21,8 +19,7 @@ export type RadioOption = {
 })
 export class RadioComponent extends ValueAccessorBase<string>{
 	@Input() options: RadioOptions;
-	@Input() orientation: Orientation = Orientation.ROW;
-	@Input() variant: 'classic' | 'button' = 'classic';
-	public Orientation = Orientation;
+	@Input() orientation: RadioOrientation = 'row';
+	@Input() variant: RadioVariant = 'classic';
 }