Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for tests to run in pre-created NS #234

Closed
wants to merge 4 commits into from

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 12, 2021

Changes

This builds upon #233 . I'm including the commits from that PR here as well and will remove them later when/if the other PR is merged

  • Define -reusenamespace flag
  • If the flag is used the test namespace is not created but re-used. The name of the namespace is typically "rekt" followed by a numeric index starting from 0. ( we used similar approach in knative/eventing). The index is increased for each new test.
  • If the flag is used then also the "eventshub" installation skips installing RBAC and rather expects the RBAC (ServiceAccount,Role, RoleBinding) to already be created. This will allow for running REKT tests by a user with reduced privileges (project admin)

I tried running the rekt tests from knative/eventing with pre-created namespaces and this flag by a project admin user. The result is:

DONE 747 tests, 8 skipped, 27 failures in 1225.891s

The failures are related to several individual tests which require clusterrole creation. These tests will need to be excluded from the execution.

/kind enhancement

Fixes #192

Release Note


Docs


@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 12, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 12, 2021
* allows for running tests in pre-created
* allows for running tests as a regular user (project admin) as long as
the namespaces and RBAC are created in advance by cluster admin
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2021
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur, pierDipi
To complete the pull request process, please assign dprotaso after the PR has been reviewed.
You can assign the PR to them by writing /assign @dprotaso in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link

@mgencur: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2021
@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2022
@knative-prow-robot
Copy link

knative-prow-robot commented Mar 24, 2022

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-tests_reconciler-test_main fbb2b50 link true /test integration-tests_reconciler-test_main

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 5, 2022
@pierDipi
Copy link
Member

pierDipi commented Jun 1, 2022

@mgencur are you still interested in this PR?

@mgencur
Copy link
Contributor Author

mgencur commented Jun 1, 2022

@pierDipi No. Let me close it. If we need it again I can create a new one but it's unlikely.

@mgencur mgencur closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for tests to run in pre-created NS
3 participants