Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Broker ingress conformance test to the new test framework #4859

Merged
merged 5 commits into from
Feb 18, 2021

Conversation

slinkydeveloper
Copy link
Contributor

Trying out the new test framework for something more than examples

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Proposed Changes

  • Ported Broker ingress conformance test to the new test framework
  • Moved broker features under features/broker

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 9, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #4859 (b1aff7f) into master (82130ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4859   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files         292      292           
  Lines        8329     8329           
=======================================
  Hits         6775     6775           
  Misses       1145     1145           
  Partials      409      409           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82130ea...5c8c83f. Read the comment docs.

@slinkydeveloper
Copy link
Contributor Author

cc @vaikas

Moved broker features under features/broker

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Copy link
Contributor Author

/retest

@lberk
Copy link
Member

lberk commented Feb 18, 2021

I like the way the ingress tests are structured! I wonder if there's
a way to also add the MUST of rejecting non-POST requests to the
broker in the future?

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2021
@slinkydeveloper
Copy link
Contributor Author

MUST of rejecting non-POST requests to the
broker in the future?

@lberk I guess we need this feature in eventshub first, it should be quite trivial to add. Can you open an issue there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants