Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated sets usages with generic version #908

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Jan 9, 2024

Changes

/kind cleanup

Partially knative/serving#14692

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2024
@knative-prow knative-prow bot requested review from mgencur and skonto January 9, 2024 07:38
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@ReToCode
Copy link
Member Author

ReToCode commented Jan 9, 2024

@dprotaso @skonto as we now also have knative/pkg#2915 merged, we need to update networking, Serving and some net-* repos to make deps bumps work again.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (964fcff) 82.18% compared to head (bc01069) 82.18%.

Files Patch % Lines
pkg/certificates/reconciler/reconciler.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #908   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files          46       46           
  Lines        1746     1746           
=======================================
  Hits         1435     1435           
  Misses        268      268           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

dprotaso commented Jan 9, 2024

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
Copy link

knative-prow bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

dprotaso commented Jan 9, 2024

/override "Unit Test (knative-extensions/net-contour)"
/override "Unit Test (knative-extensions/net-istio)"
/override "Unit Test (knative-extensions/net-kourier)"
/override "Unit Test (knative-extensions/net-certmanager)"
/override "Unit Test (knative-extensions/net-http01)"

Copy link

knative-prow bot commented Jan 9, 2024

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Unit Test (knative-extensions/net-certmanager)
  • Unit Test (knative-extensions/net-http01)

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • Unit Test (knative-extensions/net-contour)
  • Unit Test (knative-extensions/net-istio)
  • Unit Test (knative-extensions/net-kourier)
  • Unit Test (knative/serving)
  • build-tests_networking_main
  • integration-tests_networking_main
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_networking_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Unit Test (knative-extensions/net-contour)"
/override "Unit Test (knative-extensions/net-istio)"
/override "Unit Test (knative-extensions/net-kourier)"
/override "Unit Test (knative-extensions/net-certmanager)"
/override "Unit Test (knative-extensions/net-http01)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

dprotaso commented Jan 9, 2024

/override "Unit Test (knative/serving)"

Copy link

knative-prow bot commented Jan 9, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: Unit Test (knative/serving)

In response to this:

/override "Unit Test (knative/serving)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

dprotaso commented Jan 9, 2024

/override "Unit Test (knative-extensions/net-contour)"

Copy link

knative-prow bot commented Jan 9, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: Unit Test (knative-extensions/net-contour)

In response to this:

/override "Unit Test (knative-extensions/net-contour)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

dprotaso commented Jan 9, 2024

/override "Unit Test (knative-extensions/net-certmanager)"

Copy link

knative-prow bot commented Jan 9, 2024

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Unit Test (knative-extensions/net-certmanager)

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • Unit Test (knative-extensions/net-istio)
  • Unit Test (knative-extensions/net-kourier)
  • build-tests_networking_main
  • integration-tests_networking_main
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_networking_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Unit Test (knative-extensions/net-certmanager)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

dprotaso commented Jan 9, 2024

/override "Unit Test (knative-extensions/net-kourier)"
/override "Unit Test (knative-extensions/net-istio)"

Copy link

knative-prow bot commented Jan 9, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: Unit Test (knative-extensions/net-istio), Unit Test (knative-extensions/net-kourier)

In response to this:

/override "Unit Test (knative-extensions/net-kourier)"
/override "Unit Test (knative-extensions/net-istio)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 59f81e8 into knative:main Jan 9, 2024
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants