-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated sets
usages with generic version
#908
Conversation
@dprotaso @skonto as we now also have knative/pkg#2915 merged, we need to update networking, Serving and some net-* repos to make deps bumps work again. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #908 +/- ##
=======================================
Coverage 82.18% 82.18%
=======================================
Files 46 46
Lines 1746 1746
=======================================
Hits 1435 1435
Misses 268 268
Partials 43 43 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "Unit Test (knative-extensions/net-contour)" |
@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override "Unit Test (knative/serving)" |
@dprotaso: Overrode contexts on behalf of dprotaso: Unit Test (knative/serving) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override "Unit Test (knative-extensions/net-contour)" |
@dprotaso: Overrode contexts on behalf of dprotaso: Unit Test (knative-extensions/net-contour) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override "Unit Test (knative-extensions/net-certmanager)" |
@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override "Unit Test (knative-extensions/net-kourier)" |
@dprotaso: Overrode contexts on behalf of dprotaso: Unit Test (knative-extensions/net-istio), Unit Test (knative-extensions/net-kourier) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
sets
with new generic versions/kind cleanup
Partially knative/serving#14692