Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array of user agents for health check in drainer #2331

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

nader-ziada
Copy link
Member

Changes

/kind enhancement

Fixes #

Release Note

Add HealthcheckUserAgents to drainer to enable generic headers to be used for healthcheck

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 27, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2021
@nader-ziada
Copy link
Member Author

/cc @dprotaso @julz

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #2331 (2e684b4) into main (95f98e5) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
+ Coverage   64.49%   64.56%   +0.07%     
==========================================
  Files         226      226              
  Lines        9663     9668       +5     
==========================================
+ Hits         6232     6242      +10     
+ Misses       3155     3152       -3     
+ Partials      276      274       -2     
Impacted Files Coverage Δ
network/handlers/drain.go 87.50% <100.00%> (+1.22%) ⬆️
controller/controller.go 86.49% <0.00%> (+0.36%) ⬆️
test/gcs/mock/mock.go 92.47% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95f98e5...2e684b4. Read the comment docs.

Copy link
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor stuff

network/handlers/drain.go Outdated Show resolved Hide resolved
network/handlers/drain.go Outdated Show resolved Hide resolved
network/handlers/drain_test.go Outdated Show resolved Hide resolved
Copy link
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some bike shedding on the variable name & casing

note since the pkg cut had occurred this change won't be picked up till after the 1.0 release

network/handlers/drain.go Outdated Show resolved Hide resolved
network/handlers/drain.go Outdated Show resolved Hide resolved
network/handlers/drain.go Outdated Show resolved Hide resolved
network/handlers/drain.go Outdated Show resolved Hide resolved
@nader-ziada
Copy link
Member Author

note since the pkg cut had occurred this change won't be picked up till after the 1.0 release

no urgency since its mostly cleanup, will hold the serving PR until this is released

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@knative-prow-robot knative-prow-robot merged commit 6ff7fb8 into knative:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants