Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "drop eventing-rabbitmq downstream testing (#2969)" #3008

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Apr 5, 2024

This reverts commit bea8825.

Part of knative/eventing#7670

/assign @ikavgo
/assign @mkuratczyk
/assign @Zerpet

This ensures when people make changes to the shared library here we'll know if it breaks rabbitmq downstream

@knative-prow knative-prow bot requested review from creydr and ReToCode April 5, 2024 17:19
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (03bf3de) to head (2b3256a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3008      +/-   ##
==========================================
+ Coverage   78.75%   78.76%   +0.01%     
==========================================
  Files         188      188              
  Lines       11107     8869    -2238     
==========================================
- Hits         8747     6986    -1761     
+ Misses       2094     1617     -477     
  Partials      266      266              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@izabelacg
Copy link
Member

/approve

Copy link

knative-prow bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@knative-prow knative-prow bot merged commit 2cca32d into knative:main Apr 16, 2024
37 checks passed
@dprotaso dprotaso deleted the revert-rabbitmq branch April 16, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants