Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k8s deps to v0.30.3 #3084

Merged
merged 5 commits into from
Aug 12, 2024
Merged

bump k8s deps to v0.30.3 #3084

merged 5 commits into from
Aug 12, 2024

Conversation

dprotaso
Copy link
Member

  • bump k8s version
  • vendor k8s code from 1.29

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 11, 2024
@knative-prow knative-prow bot requested review from Leo6Leo and skonto August 11, 2024 18:47
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.45%. Comparing base (0991b2f) to head (d7ccfe5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   78.54%   78.45%   -0.09%     
==========================================
  Files         191      191              
  Lines        8938     8938              
==========================================
- Hits         7020     7012       -8     
- Misses       1657     1663       +6     
- Partials      261      263       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,58 @@
/*
Copyright 2016 The Kubernetes Authors.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to change this boilerplate cause I copied it from k8s.io/code-generator repo

@dprotaso
Copy link
Member Author

verify / Verify Deps and Codegen - complains go.mod file should have 1.22.0 but we had 1.22 before. I don't recall if pinning the patch is bad or not

@dprotaso
Copy link
Member Author

/override "style / Golang / Boilerplate Check (go)"

Copy link

knative-prow bot commented Aug 11, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Boilerplate Check (go)

In response to this:

/override "style / Golang / Boilerplate Check (go)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
Copy link

knative-prow bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit cd3311c into knative:main Aug 12, 2024
38 of 41 checks passed
@@ -1,6 +1,6 @@
module knative.dev/pkg

go 1.22
go 1.22.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dprotaso is there any specific reason for the go patch version in go directive? Asking for the silent error in update-deps run[1]. Or any other potential side effects?

[1] https://github.com/knative-extensions/knobots/actions/runs/10352426965/job/28653073330#step:6:430

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsimansk the go toolchain was forcing it - I couldn't figure out how to let it remain 1.22

Copy link
Contributor

@dsimansk dsimansk Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it's being forced through k8s.io modules. There's top level go.work with go 1.22.0 that's reflected through toolchain go.mod update behavior to every importing module as well.

I guess, we won't be able to get rid off for a while.

https://github.com/kubernetes/kubernetes/blob/release-1.30/staging/src/k8s.io/client-go/go.mod#L5

@dprotaso dprotaso deleted the bump-k8s-2 branch August 12, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants