-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump k8s deps to v0.30.3 #3084
bump k8s deps to v0.30.3 #3084
Conversation
dprotaso
commented
Aug 11, 2024
- bump k8s version
- vendor k8s code from 1.29
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3084 +/- ##
==========================================
- Coverage 78.54% 78.45% -0.09%
==========================================
Files 191 191
Lines 8938 8938
==========================================
- Hits 7020 7012 -8
- Misses 1657 1663 +6
- Partials 261 263 +2 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,58 @@ | |||
/* | |||
Copyright 2016 The Kubernetes Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to change this boilerplate cause I copied it from k8s.io/code-generator
repo
|
/override "style / Golang / Boilerplate Check (go)" |
@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Boilerplate Check (go) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -1,6 +1,6 @@ | |||
module knative.dev/pkg | |||
|
|||
go 1.22 | |||
go 1.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dprotaso is there any specific reason for the go patch version in go
directive? Asking for the silent error in update-deps
run[1]. Or any other potential side effects?
[1] https://github.com/knative-extensions/knobots/actions/runs/10352426965/job/28653073330#step:6:430
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsimansk the go toolchain was forcing it - I couldn't figure out how to let it remain 1.22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it's being forced through k8s.io
modules. There's top level go.work with go 1.22.0
that's reflected through toolchain go.mod
update behavior to every importing module as well.
I guess, we won't be able to get rid off for a while.
https://github.com/kubernetes/kubernetes/blob/release-1.30/staging/src/k8s.io/client-go/go.mod#L5