🧹 Give users the ability to disable namespace ownership of webhook configurations

[jonathan-innis]

Changes

Allow users to configure DisableNamespaceOwnership in webhook options. This ensures that users that have other manifest managers of ValidatingWebhookConfigurations and MutatingWebhookConfigurations don't hit conflicts when ownership is overridden.

This has specific detrimental impact when using ArgoCD which checks for ownerReferences before determining whether it should prune a resource. This has caused issues for kubernetes-sigs/karpenter, which uses knative/pkg for webhook management.

I've tested this change in the sigs.k8s.io/karpenter codebase with this commit and it's completely solved our Argo interaction issues.

/kind cleanup

Fixes knative/serving#15483

Release Note

Allow passing `DisableNamespaceOwnership` in `webhook.Options` to remove webhook ownerReferences

Docs

[knative-prow]

Hi @jonathan-innis. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.45%. Comparing base (aaab500) to head (cf5f7be).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
webhook/configmaps/configmaps.go	66.66%	1 Missing and 1 partial ⚠️
webhook/resourcesemantics/defaulting/defaulting.go	66.66%	1 Missing and 1 partial ⚠️
...k/resourcesemantics/validation/reconcile_config.go	66.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3095      +/-   ##
==========================================
- Coverage   78.47%   78.45%   -0.02%     
==========================================
  Files         191      191              
  Lines        8938     8941       +3     
==========================================
+ Hits         7014     7015       +1     
- Misses       1662     1663       +1     
- Partials      262      263       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jonathan-innis]

/assign ReToCode

[dprotaso]

Instead of adding such a knob I'm wondering if we should remove this functionality

@ReToCode @pierDipi @skonto curious about your thoughts?

Also I asked a clarifying question here: knative/serving#15483 (comment)

[dprotaso]

/ok-to-test

[dprotaso]

I'm going to approve this to unblock - but I think we should revisit the practice of the setting the owner reference here

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• webhook/OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment