Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use istio.sidecar.inject label instead of annotation #3096

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

ReToCode
Copy link
Member

Partially knative/serving#15521

Proposed Changes

  • Use istio.sidecar.inject label instead of annotation

/assign @skonto

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.45%. Comparing base (aabe552) to head (369cfcb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/crd.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3096   +/-   ##
=======================================
  Coverage   78.45%   78.45%           
=======================================
  Files         191      191           
  Lines        8938     8938           
=======================================
  Hits         7012     7012           
  Misses       1663     1663           
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
Copy link

knative-prow bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 28b58b8 into knative:main Sep 24, 2024
38 of 40 checks passed
@dprotaso
Copy link
Member

actually might need a follow up depending on the answer to this question:

knative-extensions/net-istio#1369 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants