Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.0] bump knative.dev/hack #12271

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 12, 2021

This bumps knative.dev/hack which fixes upgrade tests here: #12270

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 12, 2021
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 12, 2021
@dprotaso dprotaso changed the base branch from main to release-1.0 November 12, 2021 15:43
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2021
@dprotaso dprotaso changed the title bump knative.dev/hack [release-1.0] bump knative.dev/hack Nov 12, 2021
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, odacremolbap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features and removed lgtm Indicates that a PR is ready to be merged. labels Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #12271 (4ce95bf) into release-1.0 (f1e419a) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.0   #12271      +/-   ##
===============================================
- Coverage        87.44%   87.42%   -0.03%     
===============================================
  Files              196      196              
  Lines             9614     9612       -2     
===============================================
- Hits              8407     8403       -4     
- Misses             930      931       +1     
- Partials           277      278       +1     
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 84.61% <0.00%> (-1.54%) ⬇️
pkg/autoscaler/statforwarder/leases.go 75.53% <0.00%> (-1.44%) ⬇️
pkg/http/response_recorder.go 100.00% <0.00%> (ø)
pkg/reconciler/revision/background.go 93.20% <0.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e419a...4ce95bf. Read the comment docs.

@evankanderson
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2021
@knative-prow-robot knative-prow-robot merged commit 9fa3e2e into knative:release-1.0 Nov 12, 2021
@dprotaso dprotaso deleted the bump-hack branch February 1, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants