-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout experimental feature to the spec #76
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lionelvillard The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think we may want to have a bit of a level-setting discussion here; the goal of the I suspect that we may want to remove the "update the spec" suggestion in the eventing template, as the goal is that the Knative spec evolves more slowly than the OSS implementation, which can make experimental and backwards-incompatible changes without requiring a new spec release and vendors to update their software in order to maintain conformance. |
/hold |
<tr> | ||
<td><code>timeout</code></td> | ||
<td>string (OPTIONAL)</td> | ||
<td>The timeout of each single request.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description should indicate what the acceptable values of the string are. Is "a score of fortnights" acceptable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Serving has a timeoutSeconds
integer. Any particular reason to use a different type and name?
@pierDipi is this still relevant? |
Added timeout to the delivery spec. For more details: knative/eventing#5149