Fix address of logo on docs.rs #905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it is a better idea to include the logo locally, so we do not depend on the address of the defmt book? |
jonathanpallant
approved these changes
Dec 2, 2024
Yes, we probably should. It's not that large. |
Okay, gonna close in favor of a local image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logo is not available at the previous address anymore, since we deprecated the knurling website some time ago. This PR changes the address to the logo from the defmt book.
cargo docnow shows the logo again, but this will only solve it for new releases. The old releases will keep the old address. If we want to fix them we have to host the logo at the previous address again.Fix #904.