Fix SSRFProtect validation options to properly handle Constance settings #5205
+59
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description :
This PR addresses an issue where SSRF Protect validation fails to consider the Constance settings correctly. It now strips line break characters from the IP input before performing the SSRF Protect validation.
Testing
192.168.0.10
and192.168.0.11
inSSRF_ALLOWED_IP_ADDRESS
in Constancessrf_protect.exceptions.SSRFProtectException: URL "http://192.168.0.10" is not allowed because it resolves to a private IP address
(but could still fail because you don't have a webserver which listens on local computer).