Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Indonasian dictionary #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

koheiw
Copy link
Owner

@koheiw koheiw commented Oct 27, 2020

created by @hirokokinoshita

'LY': [Libya, Libia, Libya*, Libia*, Orang Libya, Orang Libia, Tripoli]
'MA': [Maroko, Maroko*, Orang Maroko, Rabat]
'SD': [Sudan, Sudan*, Orang Sudan, Khartoum]
'SS': [Sudan Selatan, S Sudan, Sudan Seletan*, Orang Sudan Selatan, Juba]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hirokokinoshita should we have "Sudan S" instead of "S Sudan"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep it because the word order is reversed in Indonesian language and also English is used frequently.

WEST:
'BF': [Burkina Faso, Burkina Faso*, Orang Burkina Faso, Ouagadougou]
'BJ': [Benin, Benin*, Orang Benin, Porto Novo]
'CI': [Pantai Gading, Pantai Gading*, Côte d'Ivoire, Pantai G, Orang Pantai Gading, Yamoussoukro, Abidjan]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hirokokinoshita can you check if we really need non-ASCII character like "ô".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep it English and original spellings are often used.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often do people use English place names? We can combine different languages easily using c(). For example,

> print(c(data_dictionary_newsmap_en$ASIA, data_dictionary_newsmap_ja$ASIA), 2, -1)
Dictionary object with 5 primary key entries and 2 nested levels.
- [CENTER]:
  - [KG]:
    - kyrgyzstan, kyrgyz*, bishkek, キルギスタン*, キルギス*, ビシュケク
  - [KZ]:
    - kazakhstan, kazakh*, astana, カザフスタン*, カザフ*, アスタナ
  [ reached max_nkey ... 3 more keys ]
- [EAST]:
  - [CN]:
    - china, chinese, beijing, shanghai, 中華人民共和国*, 中国*, 北京, 上海
  - [HK]:
    - hong kong, hongkongese, 香港*
  [ reached max_nkey ... 6 more keys ]
[ reached max_nkey ... 3 more keys ]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it depends on paper, media, and report, but I suppose English place names are often used. Should I remove all English place name in the dictionary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants