-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Indonasian dictionary #42
base: master
Are you sure you want to change the base?
Conversation
'LY': [Libya, Libia, Libya*, Libia*, Orang Libya, Orang Libia, Tripoli] | ||
'MA': [Maroko, Maroko*, Orang Maroko, Rabat] | ||
'SD': [Sudan, Sudan*, Orang Sudan, Khartoum] | ||
'SS': [Sudan Selatan, S Sudan, Sudan Seletan*, Orang Sudan Selatan, Juba] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hirokokinoshita should we have "Sudan S" instead of "S Sudan"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep it because the word order is reversed in Indonesian language and also English is used frequently.
WEST: | ||
'BF': [Burkina Faso, Burkina Faso*, Orang Burkina Faso, Ouagadougou] | ||
'BJ': [Benin, Benin*, Orang Benin, Porto Novo] | ||
'CI': [Pantai Gading, Pantai Gading*, Côte d'Ivoire, Pantai G, Orang Pantai Gading, Yamoussoukro, Abidjan] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hirokokinoshita can you check if we really need non-ASCII character like "ô".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep it English and original spellings are often used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How often do people use English place names? We can combine different languages easily using c()
. For example,
> print(c(data_dictionary_newsmap_en$ASIA, data_dictionary_newsmap_ja$ASIA), 2, -1)
Dictionary object with 5 primary key entries and 2 nested levels.
- [CENTER]:
- [KG]:
- kyrgyzstan, kyrgyz*, bishkek, キルギスタン*, キルギス*, ビシュケク
- [KZ]:
- kazakhstan, kazakh*, astana, カザフスタン*, カザフ*, アスタナ
[ reached max_nkey ... 3 more keys ]
- [EAST]:
- [CN]:
- china, chinese, beijing, shanghai, 中華人民共和国*, 中国*, 北京, 上海
- [HK]:
- hong kong, hongkongese, 香港*
[ reached max_nkey ... 6 more keys ]
[ reached max_nkey ... 3 more keys ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it depends on paper, media, and report, but I suppose English place names are often used. Should I remove all English place name in the dictionary?
created by @hirokokinoshita