Merge pull request #371 from pallas/json-parse-fix

json: avoid buffer overread in Json::parse_primitive
kohler · Sep 19, 2017 · 31a6577 · 31a6577
2 parents 2d413fb + 2a74ad0
commit 31a6577
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/elements/json/json.cc b/elements/json/json.cc
@@ -858,7 +858,7 @@ Json::parse_primitive(const String &str, const char *begin, const char *end)
 	    ++s;
 	    if (s != end && (*s == '+' || *s == '-'))
 		++s;
-	    if (s == end || s[1] < '0' || s[1] > '9')
+	    if (s == end || s[0] < '0' || s[0] > '9')
 		return 0;
 	    for (++s; s != end && isdigit((unsigned char) *s); )
 		++s;