Smart updates fix #268
Merged
Smart updates fix #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still needs more testing though currently, if the option is activated, all of the completed entries will have the N/A instead of the hourglass and vice versa.
cuong-tran
force-pushed
the
master
branch
3 times, most recently
from
ef268d9
to
424c7c7
Compare
|
looks fine |
still needs more testing though currently, if the option is activated, all of the completed entries will have the N/A instead of the hourglass and vice versa.
…i/komikku into smart-updates-fix-cmplt
cuong-tran
reviewed
Aug 23, 2024
app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt
Show resolved
Hide resolved
when using !in it doesn't work, so I removed the !
cuong-tran
pushed a commit
that referenced
this pull request
Aug 25, 2024
* Allow check completed entries for update if un-tick option "Skip completed..." * Always predict next-release date for all entries, even if it's completed.
cuong-tran
pushed a commit
that referenced
this pull request
Aug 25, 2024
* Allow check completed entries for update if un-tick option "Skip completed..." * Always predict next-release date for all entries, even if it's completed.
cuong-tran
pushed a commit
that referenced
this pull request
Sep 19, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 31e9273)
cuong-tran
pushed a commit
that referenced
this pull request
Sep 19, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually closes #212
I tried changing this line
.takeIf { status != SManga.COMPLETED.toLong() }to make it interact with the smart updates option, but I wasn't able to figure out how. When I thought I was going to the right direction, it would give me a "Circular dependency" error.