Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM GC: Add support for string pools over 10,000 strings #977

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,17 @@ public void contributeToInitializer(WasmFunction function) {
void.class));
function.getBody().add(new WasmCall(internInit));
}
var array = new WasmArrayNewFixed(stringsArray);
for (var str : stringMap.values()) {
array.getElements().add(new WasmGetGlobal(str.global));
var stringIterator = stringMap.values().iterator();
while (stringIterator.hasNext()) {
var elementCount = 0;
var array = new WasmArrayNewFixed(stringsArray);
// WasmArrayNewFixed cannot be larger than 10000 elements
while (elementCount < 10000 && stringIterator.hasNext()) {
array.getElements().add(new WasmGetGlobal(stringIterator.next().global));
++elementCount;
}
function.getBody().add(new WasmCall(initStringsFunction, array));
}
function.getBody().add(new WasmCall(initStringsFunction, array));
}

@Override
Expand Down