Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the sample that was using wrong apiVersion #64

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix: remove the sample that was using wrong apiVersion #64

merged 1 commit into from
Aug 23, 2023

Conversation

HarikrishnanBalagopal
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal commented Aug 23, 2023 •
edited
Loading

The correct apiVersion is move2kube.konveyor.io/v1alpha1

apiVersion: konveyor.io/v1alpha1

@HarikrishnanBalagopal
fix: remove the sample that was using wrong apiVersion
2fa2bc1 
Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Aug 23, 2023
@HarikrishnanBalagopal HarikrishnanBalagopal requested review from ashokponkumar and removed request for ashokponkumar August 23, 2023 13:59
Akash-Nayak
Akash-Nayak approved these changes Aug 23, 2023
View reviewed changes
Copy link

@Akash-Nayak Akash-Nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashokponkumar ashokponkumar merged commit 0462429 into konveyor:main Aug 23, 2023
4 checks passed
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the fix/removeinvalidsample branch August 23, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokponkumar ashokponkumar ashokponkumar approved these changes

@Akash-Nayak Akash-Nayak Akash-Nayak approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarikrishnanBalagopal @ashokponkumar @Akash-Nayak