-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ tags table change button styles #2119
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2119 +/- ##
==========================================
+ Coverage 39.20% 41.98% +2.78%
==========================================
Files 146 175 +29
Lines 4857 5630 +773
Branches 1164 1415 +251
==========================================
+ Hits 1904 2364 +460
- Misses 2939 3145 +206
- Partials 14 121 +107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
opening after running updated tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change and PR look good - one minor fix needed - remove extra table cell wrappers (see my comments below).
Signed-off-by: TalyaNeima <talya.brajtman@gmail.com>
68035c1
to
ddcfc33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mguetta1 @TalyaNaima after #2145 this will be more on the same line - the difference will be still there but I think it's a feature not a bug :) |
Closed and reopened after updating the description with UI tests PR |
Important -- This PR needs to co-merge with konveyor/tackle-ui-tests#1237. This cannot be done until a branch for release-0.6 / mta-7.2 is made in the tackle-ui-tests. |
Changing the style of the edit & delete buttons in tags table (including the tags category)
Part of #1318
UI tests PR: 1237
before the changes (using patternFly-4):
after the changes (using patternFly-5):