Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ tags table change button styles #2119

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TalyaNaima
Copy link

@TalyaNaima TalyaNaima commented Oct 8, 2024

Changing the style of the edit & delete buttons in tags table (including the tags category)

Part of #1318
UI tests PR: 1237

before the changes (using patternFly-4):
image

after the changes (using patternFly-5):
image

@TalyaNaima TalyaNaima changed the title ✨ Talya&Hadasah t table ✨ tags table change button styles Oct 8, 2024
@TalyaNaima TalyaNaima changed the title ✨ tags table change button styles ✨ tags table change button styles issue #1318 Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.98%. Comparing base (b654645) to head (c8004a0).
Report is 244 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
+ Coverage   39.20%   41.98%   +2.78%     
==========================================
  Files         146      175      +29     
  Lines        4857     5630     +773     
  Branches     1164     1415     +251     
==========================================
+ Hits         1904     2364     +460     
- Misses       2939     3145     +206     
- Partials       14      121     +107     
Flag Coverage Δ
client 41.98% <ø> (+2.78%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mguetta1 mguetta1 changed the title ✨ tags table change button styles issue #1318 ✨ tags table change button styles Oct 8, 2024
@TalyaNaima TalyaNaima closed this Oct 10, 2024
@TalyaNaima
Copy link
Author

opening after running updated tests

@TalyaNaima TalyaNaima reopened this Oct 13, 2024
Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change and PR look good - one minor fix needed - remove extra table cell wrappers (see my comments below).

client/src/app/pages/controls/tags/tags.tsx Outdated Show resolved Hide resolved
Signed-off-by: TalyaNeima <talya.brajtman@gmail.com>
Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TalyaNaima
Copy link
Author

mguetta1, noticed that the rows of tags style has changed,
the cause is that ControlTableActionButtons tags.ts has the right width only when wrapped with Td
image (1)
image

@rszwajko
Copy link
Collaborator

@mguetta1 @TalyaNaima after #2145 this will be more on the same line - the difference will be still there but I think it's a feature not a bug :)

@mguetta1
Copy link
Collaborator

Closed and reopened after updating the description with UI tests PR

@mguetta1 mguetta1 closed this Oct 31, 2024
@mguetta1 mguetta1 reopened this Oct 31, 2024
@sjd78
Copy link
Member

sjd78 commented Nov 13, 2024

Important -- This PR needs to co-merge with konveyor/tackle-ui-tests#1237. This cannot be done until a branch for release-0.6 / mta-7.2 is made in the tackle-ui-tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants